Title
u
Utkarsh Chourasia
12/03/2022, 11:38 AMHey, I want to contribute to https://github.com/questdb/go-questdb-client project. I see there is an issue open. This would be my first contribution so need a little guidances.
Until now, I have forked -> make a new branch -> started questDB server in Docker -> ???
After this I am not sure what to do next. I ran the
main.goa
Andrey Pechkurov
12/05/2022, 10:35 AMHi Utkarsh,
Server expects the following format for long256 values:
https://questdb.io/docs/reference/api/ilp/columnset-types/#long256
Client API wise I see two options:
accepts a long256 value as 4 `uint64`s
sender.
Table("trades").
Long256Column("value", 1, 2, 3, 4).
AtNow(ctx)var v Int
v.SetUint64(42)
sender.
Table("trades").
Long256Column("value", v).
AtNow(ctx)In the latter case we have to return an error on an attempt to insert a negative value (that's because long256 is an unsigned type) and also have a boundary check
math/big Int is probably more user-friendly. It will also simplify serialization code as you could use https://pkg.go.dev/math/big#Int.Append
Please let me know if you have further questions.
u
Utkarsh Chourasia
12/11/2022, 10:40 AMHi, I have implemented the
Long256Column()a
Andrey Pechkurov
12/12/2022, 7:37 AMHi Utkarsh,
Let me take a look.
The test fails since the expected value doesn't match the actual one.
Also,
123ilongOne more thing to mention: the test you've added uses a mocked server. Would be great if you could also add a test with a real server to make sure that the data is in a proper format. Such tests are in the
sender_integration_test.gou
Utkarsh Chourasia
12/12/2022, 9:28 AMOkay, I’ll fix the formatting and add integration tests as well soon. Also, if you could tell me, are there any other changes you would recommend especially in test?
a
Andrey Pechkurov
12/12/2022, 10:04 AMWe need some validation for the
<http://big.Int|big.Int><http://big.Int|big.Int>Long256Columnbuffer.WriteLongbuffer.WriteBitInt